commit 58dbf931d55f75f17ca6167b1e103ec23b39c35f Author: Zhongwei Li Date: Sun Nov 30 08:42:20 2025 +0800 Initial commit diff --git a/.claude-plugin/plugin.json b/.claude-plugin/plugin.json new file mode 100644 index 0000000..7d09a4e --- /dev/null +++ b/.claude-plugin/plugin.json @@ -0,0 +1,11 @@ +{ + "name": "code-review-standards", + "description": "Standardized code review checklist and guidelines for team consistency", + "version": "1.0.0", + "author": { + "name": "natifridman" + }, + "commands": [ + "./commands" + ] +} \ No newline at end of file diff --git a/README.md b/README.md new file mode 100644 index 0000000..c5efba8 --- /dev/null +++ b/README.md @@ -0,0 +1,3 @@ +# code-review-standards + +Standardized code review checklist and guidelines for team consistency diff --git a/commands/code-review.md b/commands/code-review.md new file mode 100644 index 0000000..de9f335 --- /dev/null +++ b/commands/code-review.md @@ -0,0 +1,57 @@ +--- +description: Provides a comprehensive code review checklist following team standards +--- + +# Code Review Standards + +You are conducting a code review following our team's established standards and best practices. Provide a thorough review covering the following areas: + +## Code Quality +- Is the code readable and well-structured? +- Are variable and function names clear and descriptive? +- Is the code following DRY (Don't Repeat Yourself) principles? +- Are there any code smells or anti-patterns? +- Is the complexity appropriate? Are there overly complex functions that should be broken down? + +## Functionality +- Does the code accomplish what it's supposed to do? +- Are edge cases handled properly? +- Is error handling comprehensive and appropriate? +- Are there any potential bugs or logical errors? + +## Testing +- Are there adequate unit tests covering the new/changed code? +- Do the tests cover edge cases and error conditions? +- Are integration tests needed and present? +- Do all tests pass? + +## Documentation +- Is there clear inline documentation for complex logic? +- Are public APIs/functions properly documented? +- Has the README been updated if needed? +- Are there any breaking changes that need to be documented? + +## Security +- Are there any security vulnerabilities (SQL injection, XSS, etc.)? +- Is user input properly validated and sanitized? +- Are secrets or sensitive data properly handled? +- Are authentication and authorization checks in place where needed? + +## Performance +- Are there any obvious performance bottlenecks? +- Is the code efficient in terms of time and space complexity? +- Are there unnecessary database queries or API calls? +- Is caching used appropriately? + +## Team Standards +- Does the code follow our style guide and formatting conventions? +- Are dependencies properly managed and documented? +- Is the commit message clear and follows our convention? +- Has the PR description adequately explained the changes? + +After reviewing, provide: +1. A summary of findings organized by severity (critical, major, minor) +2. Specific line-by-line feedback where improvements are needed +3. Positive feedback on well-implemented aspects +4. Overall recommendation: Approve, Request Changes, or Comment + diff --git a/plugin.lock.json b/plugin.lock.json new file mode 100644 index 0000000..d3f353c --- /dev/null +++ b/plugin.lock.json @@ -0,0 +1,45 @@ +{ + "$schema": "internal://schemas/plugin.lock.v1.json", + "pluginId": "gh:natifridman/claude-plugins:plugins/code-review-standards", + "normalized": { + "repo": null, + "ref": "refs/tags/v20251128.0", + "commit": "286834d540fc7a0f5b57222b35371f84dd204411", + "treeHash": "54104d7a195fbe9e3ce89727d3faacb7a01bfc00aa02e7b07a4424060cad3df4", + "generatedAt": "2025-11-28T10:27:16.753249Z", + "toolVersion": "publish_plugins.py@0.2.0" + }, + "origin": { + "remote": "git@github.com:zhongweili/42plugin-data.git", + "branch": "master", + "commit": "aa1497ed0949fd50e99e70d6324a29c5b34f9390", + "repoRoot": "/Users/zhongweili/projects/openmind/42plugin-data" + }, + "manifest": { + "name": "code-review-standards", + "description": "Standardized code review checklist and guidelines for team consistency", + "version": "1.0.0" + }, + "content": { + "files": [ + { + "path": "README.md", + "sha256": "3bde6cb50498fdeb21af426400f533fc9e61f8558d3c72a5689ab580d096d715" + }, + { + "path": ".claude-plugin/plugin.json", + "sha256": "6d8af561ca02fcc3e59f6c69d9d6c6389811cb95f5af036d0a1b361dd82ab239" + }, + { + "path": "commands/code-review.md", + "sha256": "3a914f9355c12cae7b4c5e7575636fb98f419c5cc8637d7020bf0b11838a3c59" + } + ], + "dirSha256": "54104d7a195fbe9e3ce89727d3faacb7a01bfc00aa02e7b07a4424060cad3df4" + }, + "security": { + "scannedAt": null, + "scannerVersion": null, + "flags": [] + } +} \ No newline at end of file