65 lines
2.9 KiB
HTML
65 lines
2.9 KiB
HTML
<!DOCTYPE html>
|
|
<html lang="en">
|
|
<head>
|
|
<meta charset="UTF-8">
|
|
<meta name="viewport" content="width=device-width, initial-scale=1.0">
|
|
<title>ln-332-task-reviewer - State Diagram</title>
|
|
<script src="https://cdn.jsdelivr.net/npm/mermaid@10/dist/mermaid.min.js"></script>
|
|
<link rel="stylesheet" href="../shared/css/diagram.css">
|
|
</head>
|
|
<body>
|
|
<div class="container">
|
|
<header>
|
|
<h1>🔍 ln-332-task-reviewer</h1>
|
|
<p class="subtitle">Task Reviewer - State Diagram</p>
|
|
</header>
|
|
<div class="info-box">
|
|
<h3>📋 Overview</h3>
|
|
<ul>
|
|
<li><strong>Purpose:</strong> Review tasks (To Review → Done/Rework) distinguishing test/implementation</li>
|
|
<li><strong>3 Verdicts:</strong> Accept ✅ / Minor Fixes 🔧 / Needs Rework ❌</li>
|
|
<li><strong>Checks:</strong> Universal (Architecture, DRY, KISS, YAGNI, Docs, Security) + Task Type-Specific</li>
|
|
</ul>
|
|
</div>
|
|
<div class="diagram-container">
|
|
<div class="mermaid">
|
|
graph TD
|
|
Start([Start: Review Task]) --> Phase1[Phase 1: Discovery<br/>Team ID auto-discovery]
|
|
Phase1 --> Phase2[Phase 2: Preparation<br/>Load task To Review + diffs<br/>Determine type: test/implementation]
|
|
Phase2 --> Phase3[Phase 3: Review Checklist]
|
|
subgraph Checklist [Review Checks]
|
|
C1[3.1: Universal Checks<br/>Architecture DRY KISS YAGNI<br/>Docs Security Quality<br/>No Legacy Code]
|
|
C1 --> C2[3.2: Task Type-Specific Checks<br/>If test task: test limits 10-28<br/>Priority ≥15 scenarios<br/>NO performance/load tests]
|
|
end
|
|
Phase3 --> C1
|
|
C2 --> Phase4
|
|
Phase4[Phase 4: Verdict & Update]
|
|
Phase4 --> Verdict{Verdict?}
|
|
Verdict -->|Accept ✅| Accept[Update checkboxes<br/>To Review → Done<br/>Update kanban + Commit]
|
|
Verdict -->|Minor Fixes 🔧| MinorFixes[Apply fixes<br/>To Review → Done<br/>Update kanban + Commit]
|
|
Verdict -->|Needs Rework ❌| Rework[Feedback comment<br/>To Review → To Rework<br/>Update kanban NO commit]
|
|
Accept --> End([End])
|
|
MinorFixes --> End
|
|
Rework --> End
|
|
classDef discovery fill:#E3F2FD,stroke:#1976D2,stroke-width:2px
|
|
classDef processing fill:#FFF9C4,stroke:#F57C00,stroke-width:2px
|
|
classDef decision fill:#FFE0B2,stroke:#E64A19,stroke-width:2px
|
|
classDef action fill:#C8E6C9,stroke:#388E3C,stroke-width:2px
|
|
classDef error fill:#FFCDD2,stroke:#C62828,stroke-width:2px
|
|
class Phase1,Phase2 discovery
|
|
class Phase3,C1,C2,Phase4 processing
|
|
class Verdict decision
|
|
class Accept,MinorFixes action
|
|
class Rework error
|
|
</div>
|
|
</div>
|
|
<footer>
|
|
<p>ln-332-task-reviewer | Chat prefix: 🔍 [REVIEWER]</p>
|
|
</footer>
|
|
</div>
|
|
<script>
|
|
mermaid.initialize({ startOnLoad: true, theme: 'default', flowchart: { useMaxWidth: true, htmlLabels: true, curve: 'basis' } });
|
|
</script>
|
|
</body>
|
|
</html>
|