Initial commit
This commit is contained in:
395
skills/python-style-guide/LICENSE
Normal file
395
skills/python-style-guide/LICENSE
Normal file
@@ -0,0 +1,395 @@
|
||||
Attribution 4.0 International
|
||||
|
||||
=======================================================================
|
||||
|
||||
Creative Commons Corporation ("Creative Commons") is not a law firm and
|
||||
does not provide legal services or legal advice. Distribution of
|
||||
Creative Commons public licenses does not create a lawyer-client or
|
||||
other relationship. Creative Commons makes its licenses and related
|
||||
information available on an "as-is" basis. Creative Commons gives no
|
||||
warranties regarding its licenses, any material licensed under their
|
||||
terms and conditions, or any related information. Creative Commons
|
||||
disclaims all liability for damages resulting from their use to the
|
||||
fullest extent possible.
|
||||
|
||||
Using Creative Commons Public Licenses
|
||||
|
||||
Creative Commons public licenses provide a standard set of terms and
|
||||
conditions that creators and other rights holders may use to share
|
||||
original works of authorship and other material subject to copyright
|
||||
and certain other rights specified in the public license below. The
|
||||
following considerations are for informational purposes only, are not
|
||||
exhaustive, and do not form part of our licenses.
|
||||
|
||||
Considerations for licensors: Our public licenses are
|
||||
intended for use by those authorized to give the public
|
||||
permission to use material in ways otherwise restricted by
|
||||
copyright and certain other rights. Our licenses are
|
||||
irrevocable. Licensors should read and understand the terms
|
||||
and conditions of the license they choose before applying it.
|
||||
Licensors should also secure all rights necessary before
|
||||
applying our licenses so that the public can reuse the
|
||||
material as expected. Licensors should clearly mark any
|
||||
material not subject to the license. This includes other CC-
|
||||
licensed material, or material used under an exception or
|
||||
limitation to copyright. More considerations for licensors:
|
||||
wiki.creativecommons.org/Considerations_for_licensors
|
||||
|
||||
Considerations for the public: By using one of our public
|
||||
licenses, a licensor grants the public permission to use the
|
||||
licensed material under specified terms and conditions. If
|
||||
the licensor's permission is not necessary for any reason--for
|
||||
example, because of any applicable exception or limitation to
|
||||
copyright--then that use is not regulated by the license. Our
|
||||
licenses grant only permissions under copyright and certain
|
||||
other rights that a licensor has authority to grant. Use of
|
||||
the licensed material may still be restricted for other
|
||||
reasons, including because others have copyright or other
|
||||
rights in the material. A licensor may make special requests,
|
||||
such as asking that all changes be marked or described.
|
||||
Although not required by our licenses, you are encouraged to
|
||||
respect those requests where reasonable. More_considerations
|
||||
for the public:
|
||||
wiki.creativecommons.org/Considerations_for_licensees
|
||||
|
||||
=======================================================================
|
||||
|
||||
Creative Commons Attribution 4.0 International Public License
|
||||
|
||||
By exercising the Licensed Rights (defined below), You accept and agree
|
||||
to be bound by the terms and conditions of this Creative Commons
|
||||
Attribution 4.0 International Public License ("Public License"). To the
|
||||
extent this Public License may be interpreted as a contract, You are
|
||||
granted the Licensed Rights in consideration of Your acceptance of
|
||||
these terms and conditions, and the Licensor grants You such rights in
|
||||
consideration of benefits the Licensor receives from making the
|
||||
Licensed Material available under these terms and conditions.
|
||||
|
||||
|
||||
Section 1 -- Definitions.
|
||||
|
||||
a. Adapted Material means material subject to Copyright and Similar
|
||||
Rights that is derived from or based upon the Licensed Material
|
||||
and in which the Licensed Material is translated, altered,
|
||||
arranged, transformed, or otherwise modified in a manner requiring
|
||||
permission under the Copyright and Similar Rights held by the
|
||||
Licensor. For purposes of this Public License, where the Licensed
|
||||
Material is a musical work, performance, or sound recording,
|
||||
Adapted Material is always produced where the Licensed Material is
|
||||
synched in timed relation with a moving image.
|
||||
|
||||
b. Adapter's License means the license You apply to Your Copyright
|
||||
and Similar Rights in Your contributions to Adapted Material in
|
||||
accordance with the terms and conditions of this Public License.
|
||||
|
||||
c. Copyright and Similar Rights means copyright and/or similar rights
|
||||
closely related to copyright including, without limitation,
|
||||
performance, broadcast, sound recording, and Sui Generis Database
|
||||
Rights, without regard to how the rights are labeled or
|
||||
categorized. For purposes of this Public License, the rights
|
||||
specified in Section 2(b)(1)-(2) are not Copyright and Similar
|
||||
Rights.
|
||||
|
||||
d. Effective Technological Measures means those measures that, in the
|
||||
absence of proper authority, may not be circumvented under laws
|
||||
fulfilling obligations under Article 11 of the WIPO Copyright
|
||||
Treaty adopted on December 20, 1996, and/or similar international
|
||||
agreements.
|
||||
|
||||
e. Exceptions and Limitations means fair use, fair dealing, and/or
|
||||
any other exception or limitation to Copyright and Similar Rights
|
||||
that applies to Your use of the Licensed Material.
|
||||
|
||||
f. Licensed Material means the artistic or literary work, database,
|
||||
or other material to which the Licensor applied this Public
|
||||
License.
|
||||
|
||||
g. Licensed Rights means the rights granted to You subject to the
|
||||
terms and conditions of this Public License, which are limited to
|
||||
all Copyright and Similar Rights that apply to Your use of the
|
||||
Licensed Material and that the Licensor has authority to license.
|
||||
|
||||
h. Licensor means the individual(s) or entity(ies) granting rights
|
||||
under this Public License.
|
||||
|
||||
i. Share means to provide material to the public by any means or
|
||||
process that requires permission under the Licensed Rights, such
|
||||
as reproduction, public display, public performance, distribution,
|
||||
dissemination, communication, or importation, and to make material
|
||||
available to the public including in ways that members of the
|
||||
public may access the material from a place and at a time
|
||||
individually chosen by them.
|
||||
|
||||
j. Sui Generis Database Rights means rights other than copyright
|
||||
resulting from Directive 96/9/EC of the European Parliament and of
|
||||
the Council of 11 March 1996 on the legal protection of databases,
|
||||
as amended and/or succeeded, as well as other essentially
|
||||
equivalent rights anywhere in the world.
|
||||
|
||||
k. You means the individual or entity exercising the Licensed Rights
|
||||
under this Public License. Your has a corresponding meaning.
|
||||
|
||||
|
||||
Section 2 -- Scope.
|
||||
|
||||
a. License grant.
|
||||
|
||||
1. Subject to the terms and conditions of this Public License,
|
||||
the Licensor hereby grants You a worldwide, royalty-free,
|
||||
non-sublicensable, non-exclusive, irrevocable license to
|
||||
exercise the Licensed Rights in the Licensed Material to:
|
||||
|
||||
a. reproduce and Share the Licensed Material, in whole or
|
||||
in part; and
|
||||
|
||||
b. produce, reproduce, and Share Adapted Material.
|
||||
|
||||
2. Exceptions and Limitations. For the avoidance of doubt, where
|
||||
Exceptions and Limitations apply to Your use, this Public
|
||||
License does not apply, and You do not need to comply with
|
||||
its terms and conditions.
|
||||
|
||||
3. Term. The term of this Public License is specified in Section
|
||||
6(a).
|
||||
|
||||
4. Media and formats; technical modifications allowed. The
|
||||
Licensor authorizes You to exercise the Licensed Rights in
|
||||
all media and formats whether now known or hereafter created,
|
||||
and to make technical modifications necessary to do so. The
|
||||
Licensor waives and/or agrees not to assert any right or
|
||||
authority to forbid You from making technical modifications
|
||||
necessary to exercise the Licensed Rights, including
|
||||
technical modifications necessary to circumvent Effective
|
||||
Technological Measures. For purposes of this Public License,
|
||||
simply making modifications authorized by this Section 2(a)
|
||||
(4) never produces Adapted Material.
|
||||
|
||||
5. Downstream recipients.
|
||||
|
||||
a. Offer from the Licensor -- Licensed Material. Every
|
||||
recipient of the Licensed Material automatically
|
||||
receives an offer from the Licensor to exercise the
|
||||
Licensed Rights under the terms and conditions of this
|
||||
Public License.
|
||||
|
||||
b. No downstream restrictions. You may not offer or impose
|
||||
any additional or different terms or conditions on, or
|
||||
apply any Effective Technological Measures to, the
|
||||
Licensed Material if doing so restricts exercise of the
|
||||
Licensed Rights by any recipient of the Licensed
|
||||
Material.
|
||||
|
||||
6. No endorsement. Nothing in this Public License constitutes or
|
||||
may be construed as permission to assert or imply that You
|
||||
are, or that Your use of the Licensed Material is, connected
|
||||
with, or sponsored, endorsed, or granted official status by,
|
||||
the Licensor or others designated to receive attribution as
|
||||
provided in Section 3(a)(1)(A)(i).
|
||||
|
||||
b. Other rights.
|
||||
|
||||
1. Moral rights, such as the right of integrity, are not
|
||||
licensed under this Public License, nor are publicity,
|
||||
privacy, and/or other similar personality rights; however, to
|
||||
the extent possible, the Licensor waives and/or agrees not to
|
||||
assert any such rights held by the Licensor to the limited
|
||||
extent necessary to allow You to exercise the Licensed
|
||||
Rights, but not otherwise.
|
||||
|
||||
2. Patent and trademark rights are not licensed under this
|
||||
Public License.
|
||||
|
||||
3. To the extent possible, the Licensor waives any right to
|
||||
collect royalties from You for the exercise of the Licensed
|
||||
Rights, whether directly or through a collecting society
|
||||
under any voluntary or waivable statutory or compulsory
|
||||
licensing scheme. In all other cases the Licensor expressly
|
||||
reserves any right to collect such royalties.
|
||||
|
||||
|
||||
Section 3 -- License Conditions.
|
||||
|
||||
Your exercise of the Licensed Rights is expressly made subject to the
|
||||
following conditions.
|
||||
|
||||
a. Attribution.
|
||||
|
||||
1. If You Share the Licensed Material (including in modified
|
||||
form), You must:
|
||||
|
||||
a. retain the following if it is supplied by the Licensor
|
||||
with the Licensed Material:
|
||||
|
||||
i. identification of the creator(s) of the Licensed
|
||||
Material and any others designated to receive
|
||||
attribution, in any reasonable manner requested by
|
||||
the Licensor (including by pseudonym if
|
||||
designated);
|
||||
|
||||
ii. a copyright notice;
|
||||
|
||||
iii. a notice that refers to this Public License;
|
||||
|
||||
iv. a notice that refers to the disclaimer of
|
||||
warranties;
|
||||
|
||||
v. a URI or hyperlink to the Licensed Material to the
|
||||
extent reasonably practicable;
|
||||
|
||||
b. indicate if You modified the Licensed Material and
|
||||
retain an indication of any previous modifications; and
|
||||
|
||||
c. indicate the Licensed Material is licensed under this
|
||||
Public License, and include the text of, or the URI or
|
||||
hyperlink to, this Public License.
|
||||
|
||||
2. You may satisfy the conditions in Section 3(a)(1) in any
|
||||
reasonable manner based on the medium, means, and context in
|
||||
which You Share the Licensed Material. For example, it may be
|
||||
reasonable to satisfy the conditions by providing a URI or
|
||||
hyperlink to a resource that includes the required
|
||||
information.
|
||||
|
||||
3. If requested by the Licensor, You must remove any of the
|
||||
information required by Section 3(a)(1)(A) to the extent
|
||||
reasonably practicable.
|
||||
|
||||
4. If You Share Adapted Material You produce, the Adapter's
|
||||
License You apply must not prevent recipients of the Adapted
|
||||
Material from complying with this Public License.
|
||||
|
||||
|
||||
Section 4 -- Sui Generis Database Rights.
|
||||
|
||||
Where the Licensed Rights include Sui Generis Database Rights that
|
||||
apply to Your use of the Licensed Material:
|
||||
|
||||
a. for the avoidance of doubt, Section 2(a)(1) grants You the right
|
||||
to extract, reuse, reproduce, and Share all or a substantial
|
||||
portion of the contents of the database;
|
||||
|
||||
b. if You include all or a substantial portion of the database
|
||||
contents in a database in which You have Sui Generis Database
|
||||
Rights, then the database in which You have Sui Generis Database
|
||||
Rights (but not its individual contents) is Adapted Material; and
|
||||
|
||||
c. You must comply with the conditions in Section 3(a) if You Share
|
||||
all or a substantial portion of the contents of the database.
|
||||
|
||||
For the avoidance of doubt, this Section 4 supplements and does not
|
||||
replace Your obligations under this Public License where the Licensed
|
||||
Rights include other Copyright and Similar Rights.
|
||||
|
||||
|
||||
Section 5 -- Disclaimer of Warranties and Limitation of Liability.
|
||||
|
||||
a. UNLESS OTHERWISE SEPARATELY UNDERTAKEN BY THE LICENSOR, TO THE
|
||||
EXTENT POSSIBLE, THE LICENSOR OFFERS THE LICENSED MATERIAL AS-IS
|
||||
AND AS-AVAILABLE, AND MAKES NO REPRESENTATIONS OR WARRANTIES OF
|
||||
ANY KIND CONCERNING THE LICENSED MATERIAL, WHETHER EXPRESS,
|
||||
IMPLIED, STATUTORY, OR OTHER. THIS INCLUDES, WITHOUT LIMITATION,
|
||||
WARRANTIES OF TITLE, MERCHANTABILITY, FITNESS FOR A PARTICULAR
|
||||
PURPOSE, NON-INFRINGEMENT, ABSENCE OF LATENT OR OTHER DEFECTS,
|
||||
ACCURACY, OR THE PRESENCE OR ABSENCE OF ERRORS, WHETHER OR NOT
|
||||
KNOWN OR DISCOVERABLE. WHERE DISCLAIMERS OF WARRANTIES ARE NOT
|
||||
ALLOWED IN FULL OR IN PART, THIS DISCLAIMER MAY NOT APPLY TO YOU.
|
||||
|
||||
b. TO THE EXTENT POSSIBLE, IN NO EVENT WILL THE LICENSOR BE LIABLE
|
||||
TO YOU ON ANY LEGAL THEORY (INCLUDING, WITHOUT LIMITATION,
|
||||
NEGLIGENCE) OR OTHERWISE FOR ANY DIRECT, SPECIAL, INDIRECT,
|
||||
INCIDENTAL, CONSEQUENTIAL, PUNITIVE, EXEMPLARY, OR OTHER LOSSES,
|
||||
COSTS, EXPENSES, OR DAMAGES ARISING OUT OF THIS PUBLIC LICENSE OR
|
||||
USE OF THE LICENSED MATERIAL, EVEN IF THE LICENSOR HAS BEEN
|
||||
ADVISED OF THE POSSIBILITY OF SUCH LOSSES, COSTS, EXPENSES, OR
|
||||
DAMAGES. WHERE A LIMITATION OF LIABILITY IS NOT ALLOWED IN FULL OR
|
||||
IN PART, THIS LIMITATION MAY NOT APPLY TO YOU.
|
||||
|
||||
c. The disclaimer of warranties and limitation of liability provided
|
||||
above shall be interpreted in a manner that, to the extent
|
||||
possible, most closely approximates an absolute disclaimer and
|
||||
waiver of all liability.
|
||||
|
||||
|
||||
Section 6 -- Term and Termination.
|
||||
|
||||
a. This Public License applies for the term of the Copyright and
|
||||
Similar Rights licensed here. However, if You fail to comply with
|
||||
this Public License, then Your rights under this Public License
|
||||
terminate automatically.
|
||||
|
||||
b. Where Your right to use the Licensed Material has terminated under
|
||||
Section 6(a), it reinstates:
|
||||
|
||||
1. automatically as of the date the violation is cured, provided
|
||||
it is cured within 30 days of Your discovery of the
|
||||
violation; or
|
||||
|
||||
2. upon express reinstatement by the Licensor.
|
||||
|
||||
For the avoidance of doubt, this Section 6(b) does not affect any
|
||||
right the Licensor may have to seek remedies for Your violations
|
||||
of this Public License.
|
||||
|
||||
c. For the avoidance of doubt, the Licensor may also offer the
|
||||
Licensed Material under separate terms or conditions or stop
|
||||
distributing the Licensed Material at any time; however, doing so
|
||||
will not terminate this Public License.
|
||||
|
||||
d. Sections 1, 5, 6, 7, and 8 survive termination of this Public
|
||||
License.
|
||||
|
||||
|
||||
Section 7 -- Other Terms and Conditions.
|
||||
|
||||
a. The Licensor shall not be bound by any additional or different
|
||||
terms or conditions communicated by You unless expressly agreed.
|
||||
|
||||
b. Any arrangements, understandings, or agreements regarding the
|
||||
Licensed Material not stated herein are separate from and
|
||||
independent of the terms and conditions of this Public License.
|
||||
|
||||
|
||||
Section 8 -- Interpretation.
|
||||
|
||||
a. For the avoidance of doubt, this Public License does not, and
|
||||
shall not be interpreted to, reduce, limit, restrict, or impose
|
||||
conditions on any use of the Licensed Material that could lawfully
|
||||
be made without permission under this Public License.
|
||||
|
||||
b. To the extent possible, if any provision of this Public License is
|
||||
deemed unenforceable, it shall be automatically reformed to the
|
||||
minimum extent necessary to make it enforceable. If the provision
|
||||
cannot be reformed, it shall be severed from this Public License
|
||||
without affecting the enforceability of the remaining terms and
|
||||
conditions.
|
||||
|
||||
c. No term or condition of this Public License will be waived and no
|
||||
failure to comply consented to unless expressly agreed to by the
|
||||
Licensor.
|
||||
|
||||
d. Nothing in this Public License constitutes or may be interpreted
|
||||
as a limitation upon, or waiver of, any privileges and immunities
|
||||
that apply to the Licensor or You, including from the legal
|
||||
processes of any jurisdiction or authority.
|
||||
|
||||
|
||||
=======================================================================
|
||||
|
||||
Creative Commons is not a party to its public
|
||||
licenses. Notwithstanding, Creative Commons may elect to apply one of
|
||||
its public licenses to material it publishes and in those instances
|
||||
will be considered the “Licensor.” The text of the Creative Commons
|
||||
public licenses is dedicated to the public domain under the CC0 Public
|
||||
Domain Dedication. Except for the limited purpose of indicating that
|
||||
material is shared under a Creative Commons public license or as
|
||||
otherwise permitted by the Creative Commons policies published at
|
||||
creativecommons.org/policies, Creative Commons does not authorize the
|
||||
use of the trademark "Creative Commons" or any other trademark or logo
|
||||
of Creative Commons without its prior written consent including,
|
||||
without limitation, in connection with any unauthorized modifications
|
||||
to any of its public licenses or any other arrangements,
|
||||
understandings, or agreements concerning use of licensed material. For
|
||||
the avoidance of doubt, this paragraph does not form part of the
|
||||
public licenses.
|
||||
|
||||
Creative Commons may be contacted at creativecommons.org.
|
||||
482
skills/python-style-guide/SKILL.md
Normal file
482
skills/python-style-guide/SKILL.md
Normal file
@@ -0,0 +1,482 @@
|
||||
---
|
||||
name: python-style-guide
|
||||
description: Comprehensive Python programming guidelines based on Google's Python Style Guide. Use when Claude needs to write Python code, review Python code for style issues, refactor Python code, or provide Python programming guidance. Covers language rules (imports, exceptions, type annotations), style rules (naming conventions, formatting, docstrings), and best practices for clean, maintainable Python code.
|
||||
license: Complete terms in LICENSE.txt
|
||||
---
|
||||
|
||||
# Python Style Guide
|
||||
|
||||
Comprehensive guidelines for writing clean, maintainable Python code based on [Google's Python Style Guide](https://google.github.io/styleguide/pyguide.html).
|
||||
|
||||
## Core Philosophy
|
||||
|
||||
**BE CONSISTENT.** Match the style of the code around you. Use these guidelines as defaults, but always prioritize consistency with existing code.
|
||||
|
||||
## Language Rules
|
||||
|
||||
### Imports
|
||||
|
||||
Use `import` statements for packages and modules only, not for individual classes or functions.
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
from doctor.who import jodie
|
||||
import sound_effects.utils
|
||||
```
|
||||
|
||||
**No:**
|
||||
```python
|
||||
from sound_effects.utils import EffectsRegistry # Don't import classes directly
|
||||
```
|
||||
|
||||
#### Import Formatting
|
||||
|
||||
- Group imports: standard library, third-party, application-specific
|
||||
- Alphabetize within each group
|
||||
- Use absolute imports (not relative imports)
|
||||
- One import per line (except for multiple items from `typing` or `collections.abc`)
|
||||
|
||||
```python
|
||||
# Standard library
|
||||
import os
|
||||
import sys
|
||||
|
||||
# Third-party
|
||||
import numpy as np
|
||||
import tensorflow as tf
|
||||
|
||||
# Application-specific
|
||||
from myproject.backend import api_utils
|
||||
```
|
||||
|
||||
### Exceptions
|
||||
|
||||
Use exceptions appropriately. Do not suppress errors with bare `except:` clauses.
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
try:
|
||||
result = risky_operation()
|
||||
except ValueError as e:
|
||||
logging.error(f"Invalid value: {e}")
|
||||
raise
|
||||
```
|
||||
|
||||
**No:**
|
||||
```python
|
||||
try:
|
||||
result = risky_operation()
|
||||
except: # Too broad, hides bugs
|
||||
pass
|
||||
```
|
||||
|
||||
### Type Annotations
|
||||
|
||||
Annotate all function signatures. Type annotations improve code readability and catch errors early.
|
||||
|
||||
**General rules:**
|
||||
- Annotate all public APIs
|
||||
- Use built-in types (`list`, `dict`, `set`) instead of `typing.List`, etc. (Python 3.9+)
|
||||
- Import typing symbols directly: `from typing import Any, Union`
|
||||
- Use `None` instead of `type(None)` or `NoneType`
|
||||
|
||||
```python
|
||||
def fetch_data(url: str, timeout: int = 30) -> dict[str, Any]:
|
||||
"""Fetch data from URL."""
|
||||
...
|
||||
|
||||
def process_items(items: list[str]) -> None:
|
||||
"""Process a list of items."""
|
||||
...
|
||||
```
|
||||
|
||||
### Default Argument Values
|
||||
|
||||
Never use mutable objects as default values in function definitions.
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
def foo(a: int, b: list[int] | None = None) -> None:
|
||||
if b is None:
|
||||
b = []
|
||||
```
|
||||
|
||||
**No:**
|
||||
```python
|
||||
def foo(a: int, b: list[int] = []) -> None: # Mutable default - WRONG!
|
||||
b.append(a)
|
||||
```
|
||||
|
||||
### True/False Evaluations
|
||||
|
||||
Use implicit false where possible. Empty sequences, `None`, and `0` are false in boolean contexts.
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
if not users: # Preferred
|
||||
if not some_dict:
|
||||
if value:
|
||||
```
|
||||
|
||||
**No:**
|
||||
```python
|
||||
if len(users) == 0: # Verbose
|
||||
if users == []:
|
||||
if value == True: # Never compare to True/False explicitly
|
||||
```
|
||||
|
||||
### Comprehensions & Generators
|
||||
|
||||
Use comprehensions and generators for simple cases. Keep them readable.
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
result = [x for x in data if x > 0]
|
||||
squares = (x**2 for x in range(10))
|
||||
```
|
||||
|
||||
**No:**
|
||||
```python
|
||||
# Too complex
|
||||
result = [
|
||||
x.strip().lower() for x in data
|
||||
if x and len(x) > 5 and not x.startswith('#')
|
||||
for y in x.split(',') if y
|
||||
] # Use a regular loop instead
|
||||
```
|
||||
|
||||
### Lambda Functions
|
||||
|
||||
Use lambdas for one-liners only. For anything complex, define a proper function.
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
sorted(data, key=lambda x: x.timestamp)
|
||||
```
|
||||
|
||||
**Acceptable but prefer named function:**
|
||||
```python
|
||||
def get_timestamp(item):
|
||||
return item.timestamp
|
||||
|
||||
sorted(data, key=get_timestamp)
|
||||
```
|
||||
|
||||
## Style Rules
|
||||
|
||||
### Line Length
|
||||
|
||||
Maximum line length: 80 characters. Exceptions allowed for imports, URLs, and long strings that can't be broken.
|
||||
|
||||
### Indentation
|
||||
|
||||
Use 4 spaces per indentation level. Never use tabs.
|
||||
|
||||
For hanging indents, align wrapped elements vertically or use 4-space hanging indent:
|
||||
|
||||
```python
|
||||
# Aligned with opening delimiter
|
||||
foo = long_function_name(var_one, var_two,
|
||||
var_three, var_four)
|
||||
|
||||
# Hanging indent (4 spaces)
|
||||
foo = long_function_name(
|
||||
var_one, var_two, var_three,
|
||||
var_four)
|
||||
```
|
||||
|
||||
### Blank Lines
|
||||
|
||||
- Two blank lines between top-level definitions
|
||||
- One blank line between method definitions
|
||||
- Use blank lines sparingly within functions to show logical sections
|
||||
|
||||
### Naming Conventions
|
||||
|
||||
| Type | Convention | Examples |
|
||||
|------|-----------|----------|
|
||||
| Packages/Modules | `lower_with_under` | `my_module.py` |
|
||||
| Classes | `CapWords` | `MyClass` |
|
||||
| Functions/Methods | `lower_with_under()` | `my_function()` |
|
||||
| Constants | `CAPS_WITH_UNDER` | `MAX_SIZE` |
|
||||
| Variables | `lower_with_under` | `my_var` |
|
||||
| Private | `_leading_underscore` | `_private_var` |
|
||||
|
||||
**Avoid:**
|
||||
- Single character names except for counters/iterators (`i`, `j`, `k`)
|
||||
- Dashes in any name
|
||||
- `__double_leading_and_trailing_underscore__` (reserved for Python)
|
||||
|
||||
### Comments and Docstrings
|
||||
|
||||
#### Docstring Format
|
||||
|
||||
Use Google-style docstrings for all public modules, functions, classes, and methods.
|
||||
|
||||
**Function docstring:**
|
||||
```python
|
||||
def fetch_smalltable_rows(
|
||||
table_handle: smalltable.Table,
|
||||
keys: Sequence[bytes | str],
|
||||
require_all_keys: bool = False,
|
||||
) -> Mapping[bytes, tuple[str, ...]]:
|
||||
"""Fetches rows from a Smalltable.
|
||||
|
||||
Retrieves rows pertaining to the given keys from the Table instance
|
||||
represented by table_handle. String keys will be UTF-8 encoded.
|
||||
|
||||
Args:
|
||||
table_handle: An open smalltable.Table instance.
|
||||
keys: A sequence of strings representing the key of each table
|
||||
row to fetch. String keys will be UTF-8 encoded.
|
||||
require_all_keys: If True, raise ValueError if any key is missing.
|
||||
|
||||
Returns:
|
||||
A dict mapping keys to the corresponding table row data
|
||||
fetched. Each row is represented as a tuple of strings.
|
||||
|
||||
Raises:
|
||||
IOError: An error occurred accessing the smalltable.
|
||||
ValueError: A key is missing and require_all_keys is True.
|
||||
"""
|
||||
...
|
||||
```
|
||||
|
||||
**Class docstring:**
|
||||
```python
|
||||
class SampleClass:
|
||||
"""Summary of class here.
|
||||
|
||||
Longer class information...
|
||||
Longer class information...
|
||||
|
||||
Attributes:
|
||||
likes_spam: A boolean indicating if we like SPAM or not.
|
||||
eggs: An integer count of the eggs we have laid.
|
||||
"""
|
||||
|
||||
def __init__(self, likes_spam: bool = False):
|
||||
"""Initializes the instance based on spam preference.
|
||||
|
||||
Args:
|
||||
likes_spam: Defines if instance exhibits this preference.
|
||||
"""
|
||||
self.likes_spam = likes_spam
|
||||
self.eggs = 0
|
||||
```
|
||||
|
||||
#### Block and Inline Comments
|
||||
|
||||
- Use complete sentences with proper capitalization
|
||||
- Block comments indent to the same level as the code
|
||||
- Inline comments should be separated by at least 2 spaces
|
||||
- Use inline comments sparingly
|
||||
|
||||
```python
|
||||
# Block comment explaining the following code.
|
||||
# Can span multiple lines.
|
||||
x = x + 1 # Inline comment (use sparingly)
|
||||
```
|
||||
|
||||
### Strings
|
||||
|
||||
Use f-strings for formatting (Python 3.6+).
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
x = f"name: {name}; score: {score}"
|
||||
```
|
||||
|
||||
**Acceptable:**
|
||||
```python
|
||||
x = "name: %s; score: %d" % (name, score)
|
||||
x = "name: {}; score: {}".format(name, score)
|
||||
```
|
||||
|
||||
**No:**
|
||||
```python
|
||||
x = "name: " + name + "; score: " + str(score) # Avoid + for formatting
|
||||
```
|
||||
|
||||
#### Logging
|
||||
|
||||
Use `%` formatting for logging, not f-strings (allows lazy evaluation):
|
||||
|
||||
```python
|
||||
logging.info("Request from %s resulted in %d", ip_address, status_code)
|
||||
```
|
||||
|
||||
### Files and Resources
|
||||
|
||||
Always use context managers (`with` statements) for file operations:
|
||||
|
||||
```python
|
||||
with open("file.txt") as f:
|
||||
data = f.read()
|
||||
```
|
||||
|
||||
### Statements
|
||||
|
||||
Generally avoid multiple statements on one line.
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
if foo:
|
||||
bar()
|
||||
```
|
||||
|
||||
**No:**
|
||||
```python
|
||||
if foo: bar() # Avoid
|
||||
```
|
||||
|
||||
### Main
|
||||
|
||||
For executable scripts, use:
|
||||
|
||||
```python
|
||||
def main():
|
||||
...
|
||||
|
||||
if __name__ == "__main__":
|
||||
main()
|
||||
```
|
||||
|
||||
### Function Length
|
||||
|
||||
Keep functions focused and reasonably sized. If a function exceeds about 40 lines, consider splitting it unless it remains very readable.
|
||||
|
||||
## Type Annotation Details
|
||||
|
||||
### Forward Declarations
|
||||
|
||||
Use string quotes for forward references:
|
||||
|
||||
```python
|
||||
class MyClass:
|
||||
def method(self) -> "MyClass":
|
||||
return self
|
||||
```
|
||||
|
||||
### Type Aliases
|
||||
|
||||
Create aliases for complex types:
|
||||
|
||||
```python
|
||||
from typing import TypeAlias
|
||||
|
||||
ConnectionOptions: TypeAlias = dict[str, str]
|
||||
Address: TypeAlias = tuple[str, int]
|
||||
Server: TypeAlias = tuple[Address, ConnectionOptions]
|
||||
```
|
||||
|
||||
### TypeVars
|
||||
|
||||
Use descriptive names for TypeVars:
|
||||
|
||||
```python
|
||||
from typing import TypeVar
|
||||
|
||||
_T = TypeVar("_T") # Good: private, unconstrained
|
||||
AddableType = TypeVar("AddableType", int, float, str) # Good: descriptive
|
||||
```
|
||||
|
||||
### Generics
|
||||
|
||||
Always specify type parameters for generic types:
|
||||
|
||||
**Yes:**
|
||||
```python
|
||||
def get_names(employee_ids: list[int]) -> dict[int, str]:
|
||||
...
|
||||
```
|
||||
|
||||
**No:**
|
||||
```python
|
||||
def get_names(employee_ids: list) -> dict: # Missing type parameters
|
||||
...
|
||||
```
|
||||
|
||||
### Imports for Typing
|
||||
|
||||
Import typing symbols directly:
|
||||
|
||||
```python
|
||||
from collections.abc import Mapping, Sequence
|
||||
from typing import Any, Union
|
||||
|
||||
# Use built-in types for containers (Python 3.9+)
|
||||
def foo(items: list[str]) -> dict[str, int]:
|
||||
...
|
||||
```
|
||||
|
||||
## Common Patterns
|
||||
|
||||
### Properties
|
||||
|
||||
Use properties for simple attribute access:
|
||||
|
||||
```python
|
||||
class Square:
|
||||
def __init__(self, side: float):
|
||||
self._side = side
|
||||
|
||||
@property
|
||||
def area(self) -> float:
|
||||
return self._side ** 2
|
||||
```
|
||||
|
||||
### Conditional Expressions
|
||||
|
||||
Use ternary operators for simple conditions:
|
||||
|
||||
```python
|
||||
x = "yes" if condition else "no"
|
||||
```
|
||||
|
||||
### Context Managers
|
||||
|
||||
Create custom context managers when appropriate:
|
||||
|
||||
```python
|
||||
from contextlib import contextmanager
|
||||
|
||||
@contextmanager
|
||||
def managed_resource(*args, **kwargs):
|
||||
resource = acquire_resource(*args, **kwargs)
|
||||
try:
|
||||
yield resource
|
||||
finally:
|
||||
release_resource(resource)
|
||||
```
|
||||
|
||||
## Linting
|
||||
|
||||
Run `pylint` on all Python code. Suppress warnings only when necessary with clear explanations:
|
||||
|
||||
```python
|
||||
dict = 'something' # pylint: disable=redefined-builtin
|
||||
```
|
||||
|
||||
## Summary
|
||||
|
||||
When writing Python code:
|
||||
|
||||
1. Use type annotations for all functions
|
||||
2. Follow naming conventions consistently
|
||||
3. Write clear docstrings for all public APIs
|
||||
4. Keep functions focused and reasonably sized
|
||||
5. Use comprehensions for simple cases
|
||||
6. Prefer implicit false in boolean contexts
|
||||
7. Use f-strings for formatting
|
||||
8. Always use context managers for resources
|
||||
9. Run pylint and fix issues
|
||||
10. **BE CONSISTENT** with existing code
|
||||
|
||||
## Additional Resources
|
||||
|
||||
For detailed reference on specific topics, see:
|
||||
|
||||
- **references/advanced_types.md** - Advanced type annotation patterns including Protocol, TypedDict, Literal, ParamSpec, and more
|
||||
- **references/antipatterns.md** - Common Python mistakes and their fixes
|
||||
- **references/docstring_examples.md** - Comprehensive docstring examples for all Python constructs
|
||||
259
skills/python-style-guide/references/advanced_types.md
Normal file
259
skills/python-style-guide/references/advanced_types.md
Normal file
@@ -0,0 +1,259 @@
|
||||
# Advanced Type Annotations Reference
|
||||
|
||||
This document provides detailed guidance on advanced type annotation patterns in Python.
|
||||
|
||||
## Union Types
|
||||
|
||||
Use `|` (union operator) for Python 3.10+ or `Union` for earlier versions:
|
||||
|
||||
```python
|
||||
# Python 3.10+
|
||||
def process(value: int | str) -> None:
|
||||
...
|
||||
|
||||
# Python 3.9 and earlier
|
||||
from typing import Union
|
||||
def process(value: Union[int, str]) -> None:
|
||||
...
|
||||
```
|
||||
|
||||
## Optional Types
|
||||
|
||||
`Optional[X]` is shorthand for `X | None`:
|
||||
|
||||
```python
|
||||
from typing import Optional
|
||||
|
||||
# These are equivalent:
|
||||
def foo(x: Optional[int]) -> None: ...
|
||||
def foo(x: int | None) -> None: ... # Preferred in Python 3.10+
|
||||
```
|
||||
|
||||
## Callable Types
|
||||
|
||||
For function types, use `Callable`:
|
||||
|
||||
```python
|
||||
from collections.abc import Callable
|
||||
|
||||
def apply_func(func: Callable[[int, int], int], x: int, y: int) -> int:
|
||||
return func(x, y)
|
||||
|
||||
# Callable[[arg1_type, arg2_type], return_type]
|
||||
```
|
||||
|
||||
For functions with variable arguments:
|
||||
|
||||
```python
|
||||
# Use ... for variable arguments
|
||||
def accepts_any_callable(func: Callable[..., int]) -> None:
|
||||
...
|
||||
```
|
||||
|
||||
## Sequence, Mapping, and Iterable
|
||||
|
||||
Use abstract types from `collections.abc` when you don't need specific container features:
|
||||
|
||||
```python
|
||||
from collections.abc import Sequence, Mapping, Iterable
|
||||
|
||||
def process_items(items: Sequence[str]) -> None:
|
||||
"""Works with lists, tuples, or any sequence."""
|
||||
...
|
||||
|
||||
def process_mapping(data: Mapping[str, int]) -> None:
|
||||
"""Works with dicts or any mapping."""
|
||||
...
|
||||
|
||||
def sum_numbers(nums: Iterable[int]) -> int:
|
||||
"""Works with any iterable."""
|
||||
return sum(nums)
|
||||
```
|
||||
|
||||
## Protocol and Structural Subtyping
|
||||
|
||||
Define structural types using `Protocol`:
|
||||
|
||||
```python
|
||||
from typing import Protocol
|
||||
|
||||
class Drawable(Protocol):
|
||||
def draw(self) -> None:
|
||||
...
|
||||
|
||||
def render(obj: Drawable) -> None:
|
||||
obj.draw() # Any object with a draw() method works
|
||||
```
|
||||
|
||||
## TypedDict for Structured Dictionaries
|
||||
|
||||
Use `TypedDict` for dictionaries with known keys:
|
||||
|
||||
```python
|
||||
from typing import TypedDict
|
||||
|
||||
class Employee(TypedDict):
|
||||
name: str
|
||||
id: int
|
||||
department: str
|
||||
|
||||
def process_employee(emp: Employee) -> None:
|
||||
print(emp["name"]) # Type checker knows this key exists
|
||||
```
|
||||
|
||||
Optional fields:
|
||||
|
||||
```python
|
||||
from typing import TypedDict, NotRequired
|
||||
|
||||
class Employee(TypedDict):
|
||||
name: str
|
||||
id: int
|
||||
department: NotRequired[str] # Optional field
|
||||
```
|
||||
|
||||
## Literal Types
|
||||
|
||||
Use `Literal` for specific values:
|
||||
|
||||
```python
|
||||
from typing import Literal
|
||||
|
||||
def set_mode(mode: Literal["read", "write", "append"]) -> None:
|
||||
...
|
||||
|
||||
# Type checker ensures only these values are passed
|
||||
set_mode("read") # OK
|
||||
set_mode("delete") # Error
|
||||
```
|
||||
|
||||
## Generic Classes
|
||||
|
||||
Create generic classes with `Generic`:
|
||||
|
||||
```python
|
||||
from typing import Generic, TypeVar
|
||||
|
||||
T = TypeVar("T")
|
||||
|
||||
class Stack(Generic[T]):
|
||||
def __init__(self) -> None:
|
||||
self._items: list[T] = []
|
||||
|
||||
def push(self, item: T) -> None:
|
||||
self._items.append(item)
|
||||
|
||||
def pop(self) -> T:
|
||||
return self._items.pop()
|
||||
|
||||
# Usage
|
||||
int_stack: Stack[int] = Stack()
|
||||
int_stack.push(42)
|
||||
```
|
||||
|
||||
## ParamSpec for Higher-Order Functions
|
||||
|
||||
Use `ParamSpec` to preserve function signatures:
|
||||
|
||||
```python
|
||||
from typing import ParamSpec, TypeVar, Callable
|
||||
|
||||
P = ParamSpec("P")
|
||||
R = TypeVar("R")
|
||||
|
||||
def log_calls(func: Callable[P, R]) -> Callable[P, R]:
|
||||
def wrapper(*args: P.args, **kwargs: P.kwargs) -> R:
|
||||
print(f"Calling {func.__name__}")
|
||||
return func(*args, **kwargs)
|
||||
return wrapper
|
||||
|
||||
@log_calls
|
||||
def greet(name: str, excited: bool = False) -> str:
|
||||
return f"Hello, {name}{'!' if excited else '.'}"
|
||||
|
||||
# Type checker preserves the signature of greet
|
||||
```
|
||||
|
||||
## TypeGuard for Type Narrowing
|
||||
|
||||
Use `TypeGuard` for custom type checking functions:
|
||||
|
||||
```python
|
||||
from typing import TypeGuard
|
||||
|
||||
def is_str_list(val: list[object]) -> TypeGuard[list[str]]:
|
||||
return all(isinstance(x, str) for x in val)
|
||||
|
||||
def process(items: list[object]) -> None:
|
||||
if is_str_list(items):
|
||||
# Type checker knows items is list[str] here
|
||||
print(", ".join(items))
|
||||
```
|
||||
|
||||
## Annotating *args and **kwargs
|
||||
|
||||
```python
|
||||
def foo(*args: int, **kwargs: str) -> None:
|
||||
# args is tuple[int, ...]
|
||||
# kwargs is dict[str, str]
|
||||
...
|
||||
```
|
||||
|
||||
## Overload for Multiple Signatures
|
||||
|
||||
Use `@overload` for functions with different return types based on arguments:
|
||||
|
||||
```python
|
||||
from typing import overload
|
||||
|
||||
@overload
|
||||
def process(x: int) -> int: ...
|
||||
|
||||
@overload
|
||||
def process(x: str) -> str: ...
|
||||
|
||||
def process(x: int | str) -> int | str:
|
||||
if isinstance(x, int):
|
||||
return x * 2
|
||||
return x.upper()
|
||||
```
|
||||
|
||||
## Self Type (Python 3.11+)
|
||||
|
||||
Use `Self` for methods that return the instance:
|
||||
|
||||
```python
|
||||
from typing import Self
|
||||
|
||||
class Builder:
|
||||
def add_item(self, item: str) -> Self:
|
||||
self.items.append(item)
|
||||
return self # Return type is automatically the class type
|
||||
|
||||
def build(self) -> dict:
|
||||
return {"items": self.items}
|
||||
```
|
||||
|
||||
For Python < 3.11, use TypeVar:
|
||||
|
||||
```python
|
||||
from typing import TypeVar
|
||||
|
||||
TBuilder = TypeVar("TBuilder", bound="Builder")
|
||||
|
||||
class Builder:
|
||||
def add_item(self: TBuilder, item: str) -> TBuilder:
|
||||
self.items.append(item)
|
||||
return self
|
||||
```
|
||||
|
||||
## Best Practices
|
||||
|
||||
1. Use the most general type that works (e.g., `Sequence` over `list`)
|
||||
2. Use `Protocol` for duck typing
|
||||
3. Use `TypedDict` for structured dictionaries
|
||||
4. Use `Literal` to restrict to specific values
|
||||
5. Use `TypeGuard` for custom type narrowing
|
||||
6. Always annotate public APIs
|
||||
7. Use `Any` sparingly and explicitly when needed
|
||||
8. Prefer built-in generic types (`list`, `dict`) over `typing` equivalents (Python 3.9+)
|
||||
361
skills/python-style-guide/references/antipatterns.md
Normal file
361
skills/python-style-guide/references/antipatterns.md
Normal file
@@ -0,0 +1,361 @@
|
||||
# Python Anti-Patterns and Fixes
|
||||
|
||||
Common Python mistakes and their corrections.
|
||||
|
||||
## 1. Mutable Default Arguments
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
def add_item(item, items=[]): # WRONG
|
||||
items.append(item)
|
||||
return items
|
||||
```
|
||||
|
||||
**Why it's wrong:** The list is created once when the function is defined, not each time it's called.
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
def add_item(item, items=None):
|
||||
if items is None:
|
||||
items = []
|
||||
items.append(item)
|
||||
return items
|
||||
```
|
||||
|
||||
## 2. Bare Except Clauses
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
try:
|
||||
risky_operation()
|
||||
except: # WRONG - catches everything, including KeyboardInterrupt
|
||||
handle_error()
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
try:
|
||||
risky_operation()
|
||||
except Exception as e: # Or specific exception types
|
||||
logger.error(f"Operation failed: {e}")
|
||||
handle_error()
|
||||
```
|
||||
|
||||
## 3. Using == for None Comparisons
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
if value == None: # WRONG
|
||||
...
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
if value is None:
|
||||
...
|
||||
```
|
||||
|
||||
**Why:** `is` checks identity, `==` checks equality. `None` is a singleton.
|
||||
|
||||
## 4. Comparing Boolean Values Explicitly
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
if flag == True: # WRONG
|
||||
...
|
||||
if len(items) > 0: # WRONG
|
||||
...
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
if flag:
|
||||
...
|
||||
if items:
|
||||
...
|
||||
```
|
||||
|
||||
## 5. Not Using Context Managers for Files
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
f = open("file.txt") # WRONG - file may not close if error occurs
|
||||
data = f.read()
|
||||
f.close()
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
with open("file.txt") as f:
|
||||
data = f.read()
|
||||
```
|
||||
|
||||
## 6. String Concatenation in Loops
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
result = ""
|
||||
for item in items:
|
||||
result += str(item) # WRONG - creates new string each iteration
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
result = "".join(str(item) for item in items)
|
||||
```
|
||||
|
||||
## 7. Modifying List While Iterating
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
for item in items:
|
||||
if should_remove(item):
|
||||
items.remove(item) # WRONG - skips elements
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
items = [item for item in items if not should_remove(item)]
|
||||
# Or
|
||||
items[:] = [item for item in items if not should_remove(item)]
|
||||
```
|
||||
|
||||
## 8. Using eval() or exec()
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
user_input = get_user_input()
|
||||
result = eval(user_input) # WRONG - major security risk
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
import ast
|
||||
result = ast.literal_eval(user_input) # Only evaluates literals
|
||||
```
|
||||
|
||||
## 9. Not Using enumerate()
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
i = 0
|
||||
for item in items:
|
||||
print(f"{i}: {item}")
|
||||
i += 1
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
for i, item in enumerate(items):
|
||||
print(f"{i}: {item}")
|
||||
```
|
||||
|
||||
## 10. Creating Empty Lists/Dicts Unnecessarily
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
items = []
|
||||
items.append(1)
|
||||
items.append(2)
|
||||
items.append(3)
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
items = [1, 2, 3]
|
||||
```
|
||||
|
||||
## 11. Not Using dict.get() with Defaults
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
if key in my_dict:
|
||||
value = my_dict[key]
|
||||
else:
|
||||
value = default
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
value = my_dict.get(key, default)
|
||||
```
|
||||
|
||||
## 12. Using range(len()) Instead of enumerate()
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
for i in range(len(items)):
|
||||
item = items[i]
|
||||
print(f"{i}: {item}")
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
for i, item in enumerate(items):
|
||||
print(f"{i}: {item}")
|
||||
```
|
||||
|
||||
## 13. Not Using Collections Module
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
word_counts = {}
|
||||
for word in words:
|
||||
if word in word_counts:
|
||||
word_counts[word] += 1
|
||||
else:
|
||||
word_counts[word] = 1
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
from collections import Counter
|
||||
word_counts = Counter(words)
|
||||
```
|
||||
|
||||
## 14. Not Using defaultdict
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
groups = {}
|
||||
for item in items:
|
||||
key = get_key(item)
|
||||
if key not in groups:
|
||||
groups[key] = []
|
||||
groups[key].append(item)
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
from collections import defaultdict
|
||||
groups = defaultdict(list)
|
||||
for item in items:
|
||||
key = get_key(item)
|
||||
groups[key].append(item)
|
||||
```
|
||||
|
||||
## 15. Overly Complex Comprehensions
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
result = [
|
||||
transform(x)
|
||||
for x in items
|
||||
if condition1(x)
|
||||
if condition2(x)
|
||||
if condition3(x)
|
||||
for y in x.sub_items
|
||||
if condition4(y)
|
||||
] # WRONG - too complex
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
result = []
|
||||
for x in items:
|
||||
if condition1(x) and condition2(x) and condition3(x):
|
||||
for y in x.sub_items:
|
||||
if condition4(y):
|
||||
result.append(transform(x))
|
||||
```
|
||||
|
||||
## 16. Not Using Path Objects
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
import os
|
||||
path = os.path.join(dir_name, "file.txt")
|
||||
if os.path.exists(path):
|
||||
with open(path) as f:
|
||||
...
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
from pathlib import Path
|
||||
path = Path(dir_name) / "file.txt"
|
||||
if path.exists():
|
||||
with path.open() as f:
|
||||
...
|
||||
```
|
||||
|
||||
## 17. String Formatting with + or %
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
message = "Hello, " + name + "! You have " + str(count) + " messages."
|
||||
message = "Hello, %s! You have %d messages." % (name, count)
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
message = f"Hello, {name}! You have {count} messages."
|
||||
```
|
||||
|
||||
## 18. Not Using dataclasses
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
class Point:
|
||||
def __init__(self, x, y):
|
||||
self.x = x
|
||||
self.y = y
|
||||
|
||||
def __repr__(self):
|
||||
return f"Point(x={self.x}, y={self.y})"
|
||||
|
||||
def __eq__(self, other):
|
||||
return self.x == other.x and self.y == other.y
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
from dataclasses import dataclass
|
||||
|
||||
@dataclass
|
||||
class Point:
|
||||
x: float
|
||||
y: float
|
||||
```
|
||||
|
||||
## 19. Lambda Abuse
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
process = lambda x: x.strip().lower().replace(" ", "_")[:20] # WRONG
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
def process(x: str) -> str:
|
||||
"""Clean and truncate string."""
|
||||
return x.strip().lower().replace(" ", "_")[:20]
|
||||
```
|
||||
|
||||
## 20. Not Using Sets for Membership Testing
|
||||
|
||||
**Anti-pattern:**
|
||||
```python
|
||||
valid_codes = ["A1", "A2", "A3", ...] # Long list
|
||||
if code in valid_codes: # O(n) lookup
|
||||
...
|
||||
```
|
||||
|
||||
**Fix:**
|
||||
```python
|
||||
valid_codes = {"A1", "A2", "A3", ...} # Set
|
||||
if code in valid_codes: # O(1) lookup
|
||||
...
|
||||
```
|
||||
|
||||
## Summary
|
||||
|
||||
Key principles to avoid anti-patterns:
|
||||
|
||||
1. Use built-in functions and standard library when possible
|
||||
2. Leverage context managers for resource management
|
||||
3. Use appropriate data structures (sets for membership, Counter for counting)
|
||||
4. Keep code readable and idiomatic
|
||||
5. Use modern Python features (f-strings, dataclasses, Path)
|
||||
6. Avoid premature optimization
|
||||
7. Write explicit, clear code over clever code
|
||||
384
skills/python-style-guide/references/docstring_examples.md
Normal file
384
skills/python-style-guide/references/docstring_examples.md
Normal file
@@ -0,0 +1,384 @@
|
||||
# Docstring Examples
|
||||
|
||||
Complete examples of Google-style docstrings for various Python constructs.
|
||||
|
||||
## Module Docstring
|
||||
|
||||
```python
|
||||
"""This is an example module docstring.
|
||||
|
||||
This module provides utilities for processing user data. It includes functions
|
||||
for validation, transformation, and persistence of user information.
|
||||
|
||||
Typical usage example:
|
||||
|
||||
user = create_user("John Doe", "john@example.com")
|
||||
validate_user(user)
|
||||
save_user(user)
|
||||
"""
|
||||
```
|
||||
|
||||
## Function Docstrings
|
||||
|
||||
### Simple Function
|
||||
|
||||
```python
|
||||
def greet(name: str) -> str:
|
||||
"""Returns a greeting message.
|
||||
|
||||
Args:
|
||||
name: The name of the person to greet.
|
||||
|
||||
Returns:
|
||||
A greeting string.
|
||||
"""
|
||||
return f"Hello, {name}!"
|
||||
```
|
||||
|
||||
### Function with Multiple Arguments
|
||||
|
||||
```python
|
||||
def calculate_total(
|
||||
price: float,
|
||||
quantity: int,
|
||||
discount: float = 0.0,
|
||||
tax_rate: float = 0.0
|
||||
) -> float:
|
||||
"""Calculates the total cost including discount and tax.
|
||||
|
||||
Args:
|
||||
price: The unit price of the item.
|
||||
quantity: The number of items.
|
||||
discount: The discount as a decimal (e.g., 0.1 for 10% off).
|
||||
Defaults to 0.0.
|
||||
tax_rate: The tax rate as a decimal (e.g., 0.08 for 8% tax).
|
||||
Defaults to 0.0.
|
||||
|
||||
Returns:
|
||||
The total cost after applying discount and tax.
|
||||
|
||||
Raises:
|
||||
ValueError: If price or quantity is negative.
|
||||
"""
|
||||
if price < 0 or quantity < 0:
|
||||
raise ValueError("Price and quantity must be non-negative")
|
||||
|
||||
subtotal = price * quantity * (1 - discount)
|
||||
return subtotal * (1 + tax_rate)
|
||||
```
|
||||
|
||||
### Function with Complex Return Type
|
||||
|
||||
```python
|
||||
def parse_config(
|
||||
config_path: str
|
||||
) -> tuple[dict[str, str], list[str]]:
|
||||
"""Parses a configuration file.
|
||||
|
||||
Args:
|
||||
config_path: Path to the configuration file.
|
||||
|
||||
Returns:
|
||||
A tuple containing:
|
||||
- A dictionary of configuration key-value pairs.
|
||||
- A list of warning messages encountered during parsing.
|
||||
|
||||
Raises:
|
||||
FileNotFoundError: If the config file doesn't exist.
|
||||
ValueError: If the config file is malformed.
|
||||
"""
|
||||
...
|
||||
```
|
||||
|
||||
### Function with Side Effects
|
||||
|
||||
```python
|
||||
def update_database(
|
||||
user_id: int,
|
||||
data: dict[str, Any]
|
||||
) -> None:
|
||||
"""Updates user data in the database.
|
||||
|
||||
Note:
|
||||
This function modifies the database directly. Ensure proper
|
||||
transaction handling in the calling code.
|
||||
|
||||
Args:
|
||||
user_id: The ID of the user to update.
|
||||
data: Dictionary containing fields to update.
|
||||
|
||||
Raises:
|
||||
DatabaseError: If the database operation fails.
|
||||
ValueError: If user_id is invalid or data is empty.
|
||||
"""
|
||||
...
|
||||
```
|
||||
|
||||
## Class Docstrings
|
||||
|
||||
### Simple Class
|
||||
|
||||
```python
|
||||
class User:
|
||||
"""Represents a user in the system.
|
||||
|
||||
Attributes:
|
||||
username: The user's unique username.
|
||||
email: The user's email address.
|
||||
created_at: Timestamp when the user was created.
|
||||
"""
|
||||
|
||||
def __init__(self, username: str, email: str):
|
||||
"""Initializes a new User.
|
||||
|
||||
Args:
|
||||
username: The desired username.
|
||||
email: The user's email address.
|
||||
"""
|
||||
self.username = username
|
||||
self.email = email
|
||||
self.created_at = datetime.now()
|
||||
```
|
||||
|
||||
### Complex Class with Properties
|
||||
|
||||
```python
|
||||
class Rectangle:
|
||||
"""Represents a rectangle with width and height.
|
||||
|
||||
This class provides methods for calculating area and perimeter,
|
||||
and properties for accessing dimensions.
|
||||
|
||||
Attributes:
|
||||
width: The width of the rectangle.
|
||||
height: The height of the rectangle.
|
||||
|
||||
Example:
|
||||
>>> rect = Rectangle(10, 5)
|
||||
>>> rect.area
|
||||
50
|
||||
>>> rect.perimeter
|
||||
30
|
||||
"""
|
||||
|
||||
def __init__(self, width: float, height: float):
|
||||
"""Initializes a Rectangle.
|
||||
|
||||
Args:
|
||||
width: The width of the rectangle. Must be positive.
|
||||
height: The height of the rectangle. Must be positive.
|
||||
|
||||
Raises:
|
||||
ValueError: If width or height is not positive.
|
||||
"""
|
||||
if width <= 0 or height <= 0:
|
||||
raise ValueError("Width and height must be positive")
|
||||
self._width = width
|
||||
self._height = height
|
||||
|
||||
@property
|
||||
def width(self) -> float:
|
||||
"""Gets the width of the rectangle."""
|
||||
return self._width
|
||||
|
||||
@width.setter
|
||||
def width(self, value: float) -> None:
|
||||
"""Sets the width of the rectangle.
|
||||
|
||||
Args:
|
||||
value: The new width. Must be positive.
|
||||
|
||||
Raises:
|
||||
ValueError: If value is not positive.
|
||||
"""
|
||||
if value <= 0:
|
||||
raise ValueError("Width must be positive")
|
||||
self._width = value
|
||||
|
||||
@property
|
||||
def area(self) -> float:
|
||||
"""Calculates and returns the area of the rectangle."""
|
||||
return self._width * self._height
|
||||
|
||||
@property
|
||||
def perimeter(self) -> float:
|
||||
"""Calculates and returns the perimeter of the rectangle."""
|
||||
return 2 * (self._width + self._height)
|
||||
```
|
||||
|
||||
## Generator Functions
|
||||
|
||||
```python
|
||||
def fibonacci(n: int) -> Iterator[int]:
|
||||
"""Generates the first n Fibonacci numbers.
|
||||
|
||||
Args:
|
||||
n: The number of Fibonacci numbers to generate.
|
||||
|
||||
Yields:
|
||||
The next Fibonacci number in the sequence.
|
||||
|
||||
Raises:
|
||||
ValueError: If n is negative.
|
||||
|
||||
Example:
|
||||
>>> list(fibonacci(5))
|
||||
[0, 1, 1, 2, 3]
|
||||
"""
|
||||
if n < 0:
|
||||
raise ValueError("n must be non-negative")
|
||||
|
||||
a, b = 0, 1
|
||||
for _ in range(n):
|
||||
yield a
|
||||
a, b = b, a + b
|
||||
```
|
||||
|
||||
## Exception Classes
|
||||
|
||||
```python
|
||||
class InvalidUserError(Exception):
|
||||
"""Raised when user data is invalid.
|
||||
|
||||
This exception is raised during user validation when the provided
|
||||
data doesn't meet the required criteria.
|
||||
|
||||
Attributes:
|
||||
username: The invalid username that caused the error.
|
||||
message: Explanation of the validation failure.
|
||||
"""
|
||||
|
||||
def __init__(self, username: str, message: str):
|
||||
"""Initializes the exception.
|
||||
|
||||
Args:
|
||||
username: The username that failed validation.
|
||||
message: Description of why validation failed.
|
||||
"""
|
||||
self.username = username
|
||||
self.message = message
|
||||
super().__init__(f"{username}: {message}")
|
||||
```
|
||||
|
||||
## Context Manager
|
||||
|
||||
```python
|
||||
class DatabaseConnection:
|
||||
"""Context manager for database connections.
|
||||
|
||||
Automatically handles connection setup and teardown.
|
||||
|
||||
Example:
|
||||
>>> with DatabaseConnection("localhost", 5432) as conn:
|
||||
... conn.execute("SELECT * FROM users")
|
||||
"""
|
||||
|
||||
def __init__(self, host: str, port: int):
|
||||
"""Initializes the database connection parameters.
|
||||
|
||||
Args:
|
||||
host: The database host address.
|
||||
port: The database port number.
|
||||
"""
|
||||
self.host = host
|
||||
self.port = port
|
||||
self._connection = None
|
||||
|
||||
def __enter__(self) -> "DatabaseConnection":
|
||||
"""Establishes the database connection.
|
||||
|
||||
Returns:
|
||||
The DatabaseConnection instance.
|
||||
|
||||
Raises:
|
||||
ConnectionError: If connection cannot be established.
|
||||
"""
|
||||
self._connection = create_connection(self.host, self.port)
|
||||
return self
|
||||
|
||||
def __exit__(self, exc_type, exc_val, exc_tb) -> bool:
|
||||
"""Closes the database connection.
|
||||
|
||||
Args:
|
||||
exc_type: The exception type, if an exception occurred.
|
||||
exc_val: The exception value, if an exception occurred.
|
||||
exc_tb: The exception traceback, if an exception occurred.
|
||||
|
||||
Returns:
|
||||
False to propagate exceptions, True to suppress them.
|
||||
"""
|
||||
if self._connection:
|
||||
self._connection.close()
|
||||
return False
|
||||
```
|
||||
|
||||
## Async Functions
|
||||
|
||||
```python
|
||||
async def fetch_data(url: str, timeout: float = 30.0) -> dict[str, Any]:
|
||||
"""Asynchronously fetches data from a URL.
|
||||
|
||||
Args:
|
||||
url: The URL to fetch data from.
|
||||
timeout: Maximum time to wait for response in seconds.
|
||||
Defaults to 30.0.
|
||||
|
||||
Returns:
|
||||
A dictionary containing the fetched data.
|
||||
|
||||
Raises:
|
||||
aiohttp.ClientError: If the request fails.
|
||||
asyncio.TimeoutError: If the request times out.
|
||||
|
||||
Example:
|
||||
>>> data = await fetch_data("https://api.example.com/data")
|
||||
"""
|
||||
async with aiohttp.ClientSession() as session:
|
||||
async with session.get(url, timeout=timeout) as response:
|
||||
return await response.json()
|
||||
```
|
||||
|
||||
## Test Functions
|
||||
|
||||
```python
|
||||
def test_user_creation():
|
||||
"""Tests that User objects are created correctly.
|
||||
|
||||
This test verifies:
|
||||
- Username is set correctly
|
||||
- Email is set correctly
|
||||
- created_at is set to current time
|
||||
"""
|
||||
user = User("john_doe", "john@example.com")
|
||||
assert user.username == "john_doe"
|
||||
assert user.email == "john@example.com"
|
||||
assert isinstance(user.created_at, datetime)
|
||||
```
|
||||
|
||||
## Docstring Sections
|
||||
|
||||
Common sections in Google-style docstrings:
|
||||
|
||||
- **Args:** Function/method parameters
|
||||
- **Returns:** Return value description
|
||||
- **Yields:** For generator functions
|
||||
- **Raises:** Exceptions that may be raised
|
||||
- **Attributes:** For classes, describes instance attributes
|
||||
- **Example:** Usage examples
|
||||
- **Note:** Important notes or warnings
|
||||
- **Warning:** Critical warnings
|
||||
- **Todo:** Planned improvements
|
||||
- **See Also:** Related functions or classes
|
||||
|
||||
## Style Guidelines
|
||||
|
||||
1. Use triple double quotes (`"""`) for all docstrings
|
||||
2. First line is a brief summary (one sentence, no period needed if one line)
|
||||
3. Leave a blank line before sections (Args, Returns, etc.)
|
||||
4. Capitalize section headers
|
||||
5. Use imperative mood ("Returns" not "Return")
|
||||
6. Be specific and concise
|
||||
7. Include type information in Args and Returns when not obvious from annotations
|
||||
8. Always document exceptions that can be raised
|
||||
9. Include examples for complex functions
|
||||
10. Keep line length under 80 characters where possible
|
||||
Reference in New Issue
Block a user